Create com.github.sammarxz.pomerode.json #558
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryonakano
requested changes
Feb 28, 2025
Member
ryonakano
left a comment
ryonakano
left a comment
There was a problem hiding this comment.
Your app uses Adwaita stylesheet which is not accepted (see #429 (review)). However, you don't need to subclass Gtk.Application these days and just calling Granite.init () in the startup () method of your application class (like this) should work.
| { | ||
| "source": "https://github.com/sammarxz/pomerode.git", | ||
| "commit": "6ef1f911d2d69d3bbd72e5c42b6e674c09eee085", | ||
| "version": "v1.0.0" |
Member
There was a problem hiding this comment.
You created a tag named v1.0, not v1.0.0. You need to create v1.0.0 tag on your repository
ryonakano
requested changes
Mar 16, 2025
Member
ryonakano
left a comment
ryonakano
left a comment
There was a problem hiding this comment.
You need to update the screenshots in your metainfo file to reflect changes in sammarxz/pomerode#5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review Checklist
AppData
Flatpak